Small Code Optimizations + Dependency Updates #105

mbien · 2021-10-02T20:43:06Z

a set of refactorings for better performance or more concise / easier to read code + minor version dependency updates

most of it was done by using the jackpot code inspection rules found here:
https://github.com/mbien/jackpot-inspections

…it again.

…ze]).

…ong else if chain.

snoopdave

Sorry for the relayed review. This looks great, so many nice simplifications to IO and encoding. And nice use of a switch in the request mapper.

mbien · 2021-10-23T18:15:01Z

@snoopdave no worries dave, thanks for the review!

mbien added 12 commits October 1, 2021 22:49

Use getDeviceType() of the already parsed request instead of parsing …

e23b32f

…it again.

Use StandardCharsets.UTF_8 constant instead of "UTF-8" String lookup.

eec6c79

Use Colleciton.toArray(T::new) instead of Colleciton.toArray(new T[si…

2e31b23

…ze]).

Small optimizations like better buffer sizing and switch instead of l…

86eabea

…ong else if chain.

Use collection.sort() instead of Collections.sort(col).

0832526

Use copy collection copy constructors instead of addAll().

fc8cdba

Use ByteArrayOutputStream::toString.

4de79d5

Use String::equalsIgnoreCase where applicable.

cb3090f

Use set/getProperty methods instead of Hashtable put/get.

92b9932

Use try-with-resource and input.transferTo(output) where applicable.

d6ed11c

maven dependency updates.

bf4f750

skip derby startup if tests are skipped.

1a6f44f

mbien force-pushed the optimizations branch from fcc28ad to 1a6f44f Compare October 23, 2021 05:13

mbien requested a review from snoopdave October 23, 2021 05:20

snoopdave approved these changes Oct 23, 2021

View reviewed changes

mbien merged commit 80e12ae into apache:master Oct 23, 2021

Provide feedback