[ISSUE #8755] batch send support compression #8746
Open
+139
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8746 +/- ##
=============================================
- Coverage 47.37% 47.37% -0.01%
+ Complexity 11558 11553 -5
=============================================
Files 1282 1282
Lines 89864 89890 +26
Branches 11563 11568 +5
=============================================
+ Hits 42575 42587 +12
- Misses 42040 42048 +8
- Partials 5249 5255 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
iamgd67
changed the title
iamgd67
changed the title
iamgd67
changed the title
|
ping @lizhimins for review |
|
ping @RongtongJin for review |
|
iamgd67
force-pushed
the
feature/batch_send_compression
branch
2 times, most recently
from
3db2a85
to
22c8c07
Compare
iamgd67
force-pushed
the
feature/batch_send_compression
branch
from
b2ebf53
to
7262743
Compare
|
@lizhanhui integration test added and passed |
|
ping @lollipopjin for review |
|
ping @RongtongJin for review |
|
@RongtongJin @fuyou001 @tianliuliu @lollipopjin @lizhanhui please review this， thanks. |
|
@RongtongJin @fuyou001 @tianliuliu @lollipopjin @lizhanhui please review this， thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8755
Brief Description
by default,
DefaultMQProducerwill compress message body when body length is longer than 4k, but if send with batch(send( Collection<Message> msgs)), body are not compressed.this pr compress each message body when average length is larger than 4k
How Did You Test This Change?
send and receive batch messages with 8k body(larger than 4k default compress length), check commit log content is compressed. consume message body is 8k length.