Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8720] Support disable netty server worker group by config #8721

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

lizhimins
Copy link
Member

Which Issue(s) This PR Fixes

Fixes #8720

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 47.44%. Comparing base (cab4fda) to head (267bc8d).

Files with missing lines Patch % Lines
...e/rocketmq/remoting/netty/NettyRemotingServer.java 0.00% 0 Missing and 2 partials ⚠️
...che/rocketmq/remoting/netty/NettyServerConfig.java 50.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8721      +/-   ##
=============================================
- Coverage      47.48%   47.44%   -0.04%     
+ Complexity     11536    11535       -1     
=============================================
  Files           1279     1279              
  Lines          89558    89562       +4     
  Branches       11514    11516       +2     
=============================================
- Hits           42525    42492      -33     
- Misses         41807    41844      +37     
  Partials        5226     5226              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for code review

Copy link
Contributor

@fuyou001 fuyou001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins lizhimins merged commit 845f468 into apache:develop Sep 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Support disable netty server worker group by config
4 participants