Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #8682] Add more test coverage for TopicRouteInfoManager #8683

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

[ISSUE #8682] Add more test coverage for TopicRouteInfoManager #8683

wants to merge 9 commits into from

Conversation

yx9o
Copy link
Contributor

@yx9o yx9o commented Sep 11, 2024

Fixes #8682 .

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.55%. Comparing base (d3e5f70) to head (53aa28b).

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #8683   +/-   ##
==========================================
  Coverage      47.54%   47.55%           
- Complexity     11548    11552    +4     
==========================================
  Files           1277     1277           
  Lines          89457    89457           
  Branches       11505    11505           
==========================================
+ Hits           42535    42543    +8     
+ Misses         41712    41681   -31     
- Partials        5210     5233   +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fuyou001
fuyou001 requested changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@fuyou001 fuyou001 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for code review

@yx9o
Copy link
Contributor Author

yx9o commented Sep 20, 2024

CR need

Please tell me where I need to modify. I don't understand.

@yx9o
Copy link
Contributor Author

yx9o commented Oct 10, 2024

Hi @ShannonDing , please help review, thank you.

@yx9o
Copy link
Contributor Author

yx9o commented Oct 28, 2024

Hi @RongtongJin , please help review, thank you.

DongyuanPan
DongyuanPan approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@DongyuanPan DongyuanPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuyou001 fuyou001 fuyou001 requested changes

@DongyuanPan DongyuanPan DongyuanPan approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add more test coverage for TopicRouteInfoManager
4 participants
@yx9o @codecov-commenter @fuyou001 @DongyuanPan