Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8660] feat: should use read only getConsumeQueue instead of findConsumeQueue in read only func #8659

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

absolute8511
Copy link
Contributor

@absolute8511 absolute8511 commented Sep 6, 2024

Change-Id: I9dd6a4e6074cf0e16fab51cdda57e37b116636ed

Which Issue(s) This PR Fixes

Fixes #8660

Brief Description

Since the findConsumeQueue will create the ConsumeQueue info if not exist, we should not use it in read only functions to avoid create not exist topic consume queue by accident.

How Did You Test This Change?

…e in read only func

Change-Id: I9dd6a4e6074cf0e16fab51cdda57e37b116636ed
@absolute8511 absolute8511 changed the title feat: should use read only getConsumeQueue instead of findConsumeQueue in read only func [ISSUE #8660] feat: should use read only getConsumeQueue instead of findConsumeQueue in read only func Sep 6, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 47.36%. Comparing base (0b0f8ec) to head (46ad9fe).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...org/apache/rocketmq/store/DefaultMessageStore.java 75.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8659      +/-   ##
=============================================
+ Coverage      47.26%   47.36%   +0.09%     
- Complexity     11487    11505      +18     
=============================================
  Files           1277     1277              
  Lines          89432    89438       +6     
  Branches       11502    11502              
=============================================
+ Hits           42272    42364      +92     
+ Misses         41953    41862      -91     
- Partials        5207     5212       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lizhimins lizhimins merged commit adf110f into apache:develop Sep 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] sometimes it may cause the ConsumeQueueTable info recreated in memory for not exist topic
4 participants