Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8613] fix start failed when acl2.0 authentication enabled and authorization disabled #8614

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

kingkh1995
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8613

Brief Description

How Did You Test This Change?

@kingkh1995
Copy link
Contributor Author

kingkh1995 commented Aug 30, 2024

@dingshuangxi888 can you please review my pr?

@kingkh1995 kingkh1995 changed the title #8613 fix start faild when acl2.0 authentication enabled [ISSUE #8613] fix start faild when acl2.0 authentication enabled Aug 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.49%. Comparing base (00d5047) to head (0eecd64).

Files with missing lines Patch % Lines
...th/authorization/factory/AuthorizationFactory.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8614      +/-   ##
=============================================
- Coverage      47.54%   47.49%   -0.06%     
+ Complexity     11547    11534      -13     
=============================================
  Files           1277     1277              
  Lines          89449    89449              
  Branches       11504    11504              
=============================================
- Hits           42532    42487      -45     
- Misses         41711    41744      +33     
- Partials        5206     5218      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuz10 yuz10 changed the title [ISSUE #8613] fix start faild when acl2.0 authentication enabled [ISSUE #8613] fix start faild when acl2.0 authentication enabled and authorization disabled Aug 31, 2024
@kingkh1995 kingkh1995 changed the title [ISSUE #8613] fix start faild when acl2.0 authentication enabled and authorization disabled [ISSUE #8613] fix start failed when acl2.0 authentication enabled and authorization disabled Aug 31, 2024
@dingshuangxi888
Copy link
Contributor

@dingshuangxi888 can you please review my pr?

LGTM

@yuz10 yuz10 merged commit d3e5f70 into apache:develop Sep 14, 2024
10 of 11 checks passed
@kingkh1995 kingkh1995 deleted the fix-acl2.0-getStrategy branch September 14, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] start faild when acl2.0 authentication enabled
6 participants