Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8555] Make ctx constructed in scheduleRenewTask #8556

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

qianye1001
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8555

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.06%. Comparing base (39f289a) to head (92ca2cd).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8556      +/-   ##
=============================================
- Coverage      47.08%   47.06%   -0.03%     
+ Complexity     11372    11366       -6     
=============================================
  Files           1275     1275              
  Lines          89101    89100       -1     
  Branches       11466    11466              
=============================================
- Hits           41957    41931      -26     
- Misses         41973    41980       +7     
- Partials        5171     5189      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qianye1001
Copy link
Contributor Author

@drpmma

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit 8859093 into apache:develop Aug 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Make ReceiptHandleManager easier to Enhance renew
3 participants