[ISSUE #8166]optimize: make compression type configurable in producer clinet level #8167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humkum
force-pushed
the
optimize-compress
branch
2 times, most recently
from
1ab1d20
to
98f0162
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8167 +/- ##
=============================================
- Coverage 42.92% 42.89% -0.03%
+ Complexity 10372 10368 -4
=============================================
Files 1270 1270
Lines 88696 88698 +2
Branches 11402 11402
=============================================
- Hits 38072 38050 -22
- Misses 45922 45943 +21
- Partials 4702 4705 +3 ☔ View full report in Codecov by Sentry. |
RongtongJin
reviewed
May 21, 2024
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
Show resolved
Hide resolved
cserwen
approved these changes
May 21, 2024
ferrirW
approved these changes
May 21, 2024
RongtongJin
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #8166
Brief Description
Configure production compression at the producer instance level instead of at the process level.
How Did You Test This Change?
Producer configure the compression type with "ZSTD", and send message who's body over 4KB, debug the compression type producer use is ZSTDCompressor.