Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8145] Optimize some code style in client module #8146

Merged
merged 1 commit into from
May 16, 2024

Conversation

Willhow-Gao
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #8145

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 61.90476% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 42.91%. Comparing base (03b16aa) to head (21fcf9a).
Report is 1 commits behind head on develop.

Files Patch % Lines
...mq/client/impl/producer/DefaultMQProducerImpl.java 57.14% 2 Missing and 4 partials ⚠️
...rocketmq/client/impl/factory/MQClientInstance.java 66.66% 1 Missing ⚠️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8146      +/-   ##
=============================================
- Coverage      42.93%   42.91%   -0.03%     
+ Complexity     10386    10377       -9     
=============================================
  Files           1270     1270              
  Lines          88693    88689       -4     
  Branches       11401    11402       +1     
=============================================
- Hits           38083    38060      -23     
- Misses         45920    45931      +11     
- Partials        4690     4698       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin RongtongJin merged commit 8150e13 into apache:develop May 16, 2024
10 checks passed
@Willhow-Gao Willhow-Gao deleted the fix-code-style branch May 27, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize some code style in client module
3 participants