-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #8053] Return SYSTEM_BUSY if PutMessageStatus is OS_PAGE_CACHE_BUSY #8054
[ISSUE #8053] Return SYSTEM_BUSY if PutMessageStatus is OS_PAGE_CACHE_BUSY #8054
Conversation
58e1bde
to
91c4f43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From another perspective, semantically returning busy is indeed more reasonable than error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is correct to change the response code, but we need more discussion on whether client should retry on this scenario. Personally I think the client should retry by default to avoid producing failure.
I agree with you |
There has been a lot of discussion about whether system_busy should be retried. I personally support retrying. For details, please refer to #5845 @yuz10 |
@biningo merge develop to fix the ut |
91c4f43
to
e148e32
Compare
okay, I have merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8054 +/- ##
=============================================
- Coverage 42.94% 42.88% -0.07%
+ Complexity 10387 10369 -18
=============================================
Files 1270 1270
Lines 88694 88693 -1
Branches 11401 11401
=============================================
- Hits 38092 38037 -55
- Misses 45914 45949 +35
- Partials 4688 4707 +19 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May affect old clients.
Which Issue(s) This PR Fixes
Fixes #8053