Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7988] Refector client trace #7989

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Conversation

drpmma
Copy link
Contributor

@drpmma drpmma commented Mar 29, 2024

Which Issue(s) This PR Fixes

Fixes #7988

Brief Description

  • build trace dispatcher in start method
  • setNamespaceV2 for dispatcher
  • disable trace for inner traceProducer

How Did You Test This Change?

* build trace dispatcher in start method
* setNamespaceV2 for dispatcher
* disable trace for inner traceProducer
HScarb
HScarb previously approved these changes Mar 30, 2024
Copy link
Contributor

@dingshuangxi888 dingshuangxi888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 67.69231% with 21 lines in your changes missing coverage. Please review.

Project coverage is 42.88%. Comparing base (d2818da) to head (cbb26aa).
Report is 160 commits behind head on develop.

Files with missing lines Patch % Lines
...ocketmq/client/consumer/DefaultMQPushConsumer.java 61.90% 7 Missing and 1 partial ⚠️
...he/rocketmq/client/producer/DefaultMQProducer.java 68.42% 5 Missing and 1 partial ⚠️
...ketmq/client/consumer/DefaultLitePullConsumer.java 55.55% 3 Missing and 1 partial ⚠️
.../java/org/apache/rocketmq/client/ClientConfig.java 81.81% 2 Missing ⚠️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 80.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7989      +/-   ##
=============================================
+ Coverage      42.84%   42.88%   +0.03%     
+ Complexity     10353    10349       -4     
=============================================
  Files           1270     1270              
  Lines          88646    88666      +20     
  Branches       11399    11397       -2     
=============================================
+ Hits           37980    38020      +40     
+ Misses         45979    45956      -23     
- Partials        4687     4690       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drpmma drpmma merged commit 88e6447 into apache:develop Apr 2, 2024
10 checks passed
yuz10 pushed a commit to yuz10/rocketmq that referenced this pull request Apr 23, 2024
* [ISSUE apache#7988] Refector client trace

* build trace dispatcher in start method
* setNamespaceV2 for dispatcher
* disable trace for inner traceProducer
* fix tls
yuz10 added a commit that referenced this pull request Jun 13, 2024
* [ISSUE #7988] Refector client trace (#7989)

* [ISSUE #7988] Refector client trace

* build trace dispatcher in start method
* setNamespaceV2 for dispatcher
* disable trace for inner traceProducer
* fix tls

* [ISSUE #7988] Set enableTrace default to false

---------

Co-authored-by: Zhouxiang Zhan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Refector client trace
5 participants