-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #7988] Refector client trace #7989
Conversation
* build trace dispatcher in start method * setNamespaceV2 for dispatcher * disable trace for inner traceProducer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7989 +/- ##
=============================================
+ Coverage 42.84% 42.88% +0.03%
+ Complexity 10353 10349 -4
=============================================
Files 1270 1270
Lines 88646 88666 +20
Branches 11399 11397 -2
=============================================
+ Hits 37980 38020 +40
+ Misses 45979 45956 -23
- Partials 4687 4690 +3 ☔ View full report in Codecov by Sentry. |
* [ISSUE apache#7988] Refector client trace * build trace dispatcher in start method * setNamespaceV2 for dispatcher * disable trace for inner traceProducer * fix tls
* [ISSUE #7988] Refector client trace (#7989) * [ISSUE #7988] Refector client trace * build trace dispatcher in start method * setNamespaceV2 for dispatcher * disable trace for inner traceProducer * fix tls * [ISSUE #7988] Set enableTrace default to false --------- Co-authored-by: Zhouxiang Zhan <[email protected]>
Which Issue(s) This PR Fixes
Fixes #7988
Brief Description
How Did You Test This Change?