Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7983]Use java optional #7984

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

ChineseTony
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #7983

Brief Description

How Did You Test This Change?

@ChineseTony ChineseTony changed the title [ISSUE #7983]Fix log class error Use java optional [ISSUE #7983]Use java optional Mar 28, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 42.84%. Comparing base (fa811dc) to head (f1a82ae).
Report is 1 commits behind head on develop.

Files Patch % Lines
...mq/client/impl/producer/DefaultMQProducerImpl.java 0.00% 1 Missing ⚠️
...ocketmq/proxy/service/route/TopicRouteService.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #7984   +/-   ##
==========================================
  Coverage      42.84%   42.84%           
- Complexity     10345    10352    +7     
==========================================
  Files           1270     1270           
  Lines          88648    88646    -2     
  Branches       11399    11399           
==========================================
  Hits           37977    37977           
- Misses         45979    45981    +2     
+ Partials        4692     4688    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin RongtongJin merged commit 28565a3 into apache:develop Apr 1, 2024
10 checks passed
@ChineseTony ChineseTony deleted the use_java_optional branch April 1, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Use java optional rather than guava opttional ,and remove the dependency
4 participants