Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume request count threshold log fix #7969

Merged

Conversation

iamgd67
Copy link
Contributor

@iamgd67 iamgd67 commented Mar 26, 2024

simple and clear change, not creating an issue

Brief Description

log.warn("The consume request count exceeds threshold {}, so do flow control, consume request count={}, flowControlTimes={}", consumeRequestCache.size(), consumeRequestFlowControlTimes);

missing first parameter, so out put is corrupt

2024-03-26 13:48:53.235 WARN  [15008] [PullMsgThread-test20] [o.a.r.c.i.c.DefaultLitePullConsumerImpl#run:903] - The consume request count exceeds threshold 101, so do flow control, consume request count=1, flowControlTimes={}

How Did You Test This Change?

after change

log.warn("The consume request count exceeds threshold {}, so do flow control, consume request count={}, flowControlTimes={}",
                                (int)Math.ceil((double)defaultLitePullConsumer.getPullThresholdForAll()/defaultLitePullConsumer.getPullBatchSize()),
                                consumeRequestCache.size(), consumeRequestFlowControlTimes);

out put is good

2024-03-26 16:55:00.813 WARN  [29212] [PullMsgThread-test11] [o.a.r.c.i.c.DefaultLitePullConsumerImpl#run:904] - The consume request count exceeds threshold 100, so do flow control, consume request count=116, flowControlTimes=2001

@iamgd67 iamgd67 force-pushed the consume_request_count_threshold_log_fix branch from aea1d33 to e543b8a Compare March 27, 2024 00:29
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.82%. Comparing base (d9c75ff) to head (e543b8a).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7969      +/-   ##
=============================================
- Coverage      42.83%   42.82%   -0.01%     
- Complexity     10345    10350       +5     
=============================================
  Files           1270     1270              
  Lines          88619    88621       +2     
  Branches       11395    11395              
=============================================
- Hits           37960    37956       -4     
- Misses         45967    45982      +15     
+ Partials        4692     4683       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iamgd67
Copy link
Contributor Author

iamgd67 commented Mar 27, 2024

ping @RongtongJin for review

@iamgd67
Copy link
Contributor Author

iamgd67 commented Mar 27, 2024

ping @lizhimins for review

@iamgd67
Copy link
Contributor Author

iamgd67 commented Mar 28, 2024

ping @lollipopjin for review

@RongtongJin RongtongJin merged commit fa811dc into apache:develop Mar 28, 2024
10 checks passed
@iamgd67 iamgd67 deleted the consume_request_count_threshold_log_fix branch March 28, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants