Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some ambiguous logs #7934

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Fix some ambiguous logs #7934

merged 2 commits into from
Mar 18, 2024

Conversation

caizhaomin1
Copy link
Contributor

Which Issue(s) This PR Fixes

I only modified the log printed, the modification isn't complicated, so I didn't submit an issue.

Brief Description

I was reading the code about namesrv and broker, and i found some ambiguous logs, this pr is to fix them.

How Did You Test This Change?

Nonthing logical is modified, i think there is no need for a test.

@RongtongJin
Copy link
Contributor

@caizhaomin1 It would be better to submit a relevant issue.

Copy link
Contributor

@RongtongJin RongtongJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 42.92%. Comparing base (a32eca0) to head (4433612).

Files Patch % Lines
...e/rocketmq/namesrv/routeinfo/RouteInfoManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7934      +/-   ##
=============================================
- Coverage      42.94%   42.92%   -0.02%     
+ Complexity      9913     9909       -4     
=============================================
  Files           1190     1190              
  Lines          86042    86042              
  Branches       11081    11081              
=============================================
- Hits           36950    36936      -14     
- Misses         44514    44534      +20     
+ Partials        4578     4572       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RongtongJin RongtongJin merged commit 9ab37b9 into apache:develop Mar 18, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants