Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix document typo #7721

Merged
merged 1 commit into from
Mar 13, 2024
Merged

fix document typo #7721

merged 1 commit into from
Mar 13, 2024

Conversation

zjko
Copy link
Contributor

@zjko zjko commented Jan 3, 2024

Which Issue(s) This PR Fixes

Fixes #issue_id

Brief Description

avoid confusion

How Did You Test This Change?

no code change

@@ -26,9 +26,9 @@ deleteWhen = 04
fileReservedTime = 48
brokerRole = ASYNC_MASTER
flushDiskType = ASYNC_FLUSH
namesrvAddr = 127.0.0.1:9876 # name server地址
Copy link
Contributor Author

@zjko zjko Jan 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted this comment to avoid startup failure.
The Name Server Address[127.0.0.1:9876 # name server��] illegal, please set it as follows, "127.0.0.1:9876;192.168.0.1:9876"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you should not paste the commented content in the terminal

@zjko
Copy link
Contributor Author

zjko commented Jan 3, 2024

Hi @joeCarf , Could you plz help review this PR?

Copy link
Contributor

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caigy caigy merged commit 72bd03c into apache:develop Mar 13, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants