[ISSUE #7710] Handle blank string for UtilAll#split to fix the bugs of ACL #7712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RongtongJin
changed the title
RongtongJin
reviewed
Jan 2, 2024
Qinglong-Lee
force-pushed
the
bugfix-ACL_ISSUE_by_UtilAll#split
branch
from
40f7838
to
5a82142
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #7712 +/- ##
=============================================
- Coverage 43.18% 43.16% -0.02%
+ Complexity 9821 9809 -12
=============================================
Files 1165 1165
Lines 84546 84548 +2
Branches 10979 10980 +1
=============================================
- Hits 36510 36496 -14
- Misses 43503 43509 +6
- Partials 4533 4543 +10 ☔ View full report in Codecov by Sentry. |
RongtongJin
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7710
Brief Description
The PR is for a bug the ACL, which caused the problem of deleting the last item of the topic/group perms or the global white list.
The bug is due to the flaw of UtilAll#split func which didn't handle the blank string case properly.
So I've fixed it.
How Did You Test This Change?
This change have been tested by unit test and the bug have been tested on local.
I've also searched the usages of the changed method globally.
I'm sure the bug has been fixed and has no influence on any other functions of the project.