-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #7757] Use CompositeByteBuf
to prevent memory copy.
#7694
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #7694 +/- ##
=============================================
- Coverage 43.20% 43.16% -0.04%
- Complexity 9028 9808 +780
=============================================
Files 1107 1165 +58
Lines 78269 84545 +6276
Branches 10202 10980 +778
=============================================
+ Hits 33813 36493 +2680
- Misses 40222 43506 +3284
- Partials 4234 4546 +312 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to provide some performance comparison data.
CompositeByteBuf
to prevent memory copy.CompositeByteBuf
to prevent memory copy.
Brief Description
Use
CompositeByteBuf
instead ofDirectByteBuf
to prevent memory copy.How Did You Test This Change?
Existing tests could cover the case.