Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7757] Use CompositeByteBuf to prevent memory copy. #7694

Merged
merged 6 commits into from
Jan 17, 2024

Conversation

dao-jun
Copy link
Member

@dao-jun dao-jun commented Dec 23, 2023

Brief Description

Use CompositeByteBuf instead of DirectByteBuf to prevent memory copy.

How Did You Test This Change?

Existing tests could cover the case.

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0d516ba) 43.20% compared to head (038e832) 43.16%.
Report is 308 commits behind head on develop.

Files Patch % Lines
...che/rocketmq/remoting/netty/FileRegionEncoder.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7694      +/-   ##
=============================================
- Coverage      43.20%   43.16%   -0.04%     
- Complexity      9028     9808     +780     
=============================================
  Files           1107     1165      +58     
  Lines          78269    84545    +6276     
  Branches       10202    10980     +778     
=============================================
+ Hits           33813    36493    +2680     
- Misses         40222    43506    +3284     
- Partials        4234     4546     +312     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

RongtongJin
RongtongJin previously approved these changes Dec 27, 2023
Copy link
Contributor

@RongtongJin RongtongJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to provide some performance comparison data.

RongtongJin
RongtongJin previously approved these changes Jan 15, 2024
@RongtongJin RongtongJin changed the title [improve] Use CompositeByteBuf to prevent memory copy. [ISSUE #7757] Use CompositeByteBuf to prevent memory copy. Jan 17, 2024
@RongtongJin RongtongJin merged commit 7a36d4d into apache:develop Jan 17, 2024
8 of 10 checks passed
@dao-jun dao-jun deleted the dev/mem_copy branch January 17, 2024 09:07
yuz10 added a commit that referenced this pull request May 27, 2024
RongtongJin pushed a commit that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants