Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7684] Fix iterator.remove() bug #7682

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Conversation

EvanMi
Copy link
Contributor

@EvanMi EvanMi commented Dec 19, 2023

Brief Description

bugfix: CopyOnWriteArray#listIterator do not support remove action when iterating

@RongtongJin
Copy link
Contributor

Hi @EvanMi Could you create an issue related the pr?

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9dec4cf) 43.12% compared to head (7bff5a7) 43.19%.
Report is 1 commits behind head on develop.

Files Patch % Lines
...ava/org/apache/rocketmq/store/MappedFileQueue.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #7682      +/-   ##
=============================================
+ Coverage      43.12%   43.19%   +0.07%     
- Complexity      9793     9806      +13     
=============================================
  Files           1165     1165              
  Lines          84482    84485       +3     
  Branches       10968    10969       +1     
=============================================
+ Hits           36429    36492      +63     
+ Misses         43523    43465      -58     
+ Partials        4530     4528       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EvanMi
Copy link
Contributor Author

EvanMi commented Dec 20, 2023

Hi @EvanMi Could you create an issue related the pr?

see #7684

@RongtongJin RongtongJin changed the title fix iterator.remove() bug Fix iterator.remove() bug Dec 20, 2023
@RongtongJin RongtongJin changed the title Fix iterator.remove() bug [ISSUE #7684] Fix iterator.remove() bug Dec 20, 2023
@RongtongJin RongtongJin merged commit f0a3e93 into apache:develop Dec 20, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants