[ISSUE #7656] ConfirmOffset directly takes the max offset when allAckInSyncStateSet is false #7657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #7657 +/- ##
=============================================
+ Coverage 43.19% 43.24% +0.05%
- Complexity 9812 9821 +9
=============================================
Files 1165 1165
Lines 84461 84462 +1
Branches 10964 10965 +1
=============================================
+ Hits 36482 36525 +43
+ Misses 43454 43415 -39
+ Partials 4525 4522 -3 ☔ View full report in Codecov by Sentry. |
ShannonDing
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7656
Brief Description
ConfirmOffset directly takes the max offset when allAckInSyncStateSet is false
How Did You Test This Change?