[ISSUE #7601] Fix slave acting master bug

[gaoyf]

Which Issue(s) This PR Fixes

Fixes #7601

Brief Description

Fix #7601's exception and master use slave's TimerCheckPoint。

How Did You Test This Change?

Use #7601's reproduce step to test.

[codecov-commenter]

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (65faea2) 43.19% compared to head (3509621) 43.16%.

Files	Patch %	Lines
...apache/rocketmq/store/timer/TimerMessageStore.java	0.00%	4 Missing ⚠️
...apache/rocketmq/broker/slave/SlaveSynchronize.java	0.00%	3 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #7603      +/-   ##
=============================================
- Coverage      43.19%   43.16%   -0.03%     
- Complexity      9782     9783       +1     
=============================================
  Files           1162     1162              
  Lines          84378    84381       +3     
  Branches       10955    10957       +2     
=============================================
- Hits           36451    36427      -24     
- Misses         43397    43434      +37     
+ Partials        4530     4520      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joeCarf]

could you explain why comment these lines and how the second bug occurs?

[gaoyf]

I extracted TimerDequeuePutMessageService‘s some key codes, as follows:

while (!isStopped() && !doRes) {
    try {
        MessageExtBrokerInner msg = convert(msgExt, tr.getEnqueueTime(), needRoll(tr.getMagic()));
        doRes = PUT_NEED_RETRY != doPut(msg, needRoll(tr.getMagic()));
    } catch (Throwable t) {
        LOGGER.info("Unknown error", t);
    }
}

If method doPut throw exception, the logic try to execute method convert in a loop。
However, MessageExtBrokerInner and MessageExt hold the same Map of properties, convertMessage FYI, so the following code will return null:

msgInner.getProperty(MessageConst.PROPERTY_REAL_TOPIC)
msgInner.getProperty(MessageConst.PROPERTY_REAL_QUEUE_ID)

Because property MessageConst.PROPERTY_REAL_QUEUE_ID has been removed in the first execution.
So canot remove these properties for the retry logic.
On the other hand，the original logic: MessageExtBrokerInner will be reputed to commitlog，it will contains property MessageConst.PROPERTY_REAL_TOPIC and MessageConst.PROPERTY_REAL_TOPIC，because the fllowing code:

msgInner.setPropertiesString(MessageDecoder.messageProperties2String(msgExt.getProperties()));

That is to say, when retrieving this message, it must contains these two properties，So I don't think commenting out these codes will affect the original logic.

[RongtongJin]

Alternatively, we should add a messageAccessior.deepCopyProperties instead of using the same reference.

[gaoyf]

Alternatively, we should add a messageAccessior.deepCopyProperties instead of using the same reference.

Your idea looks better, although I don't think commenting out this code will have any impact，but I modified the code as you suggested.