[ISSUE #7534] use high performance concurrent set to replace copyonwriteset #7583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeCarf
reviewed
Nov 27, 2023
| Set<String> copyOnWriteArraySet = new CopyOnWriteArraySet<>(); | ||
| HashSet<String> topics= new HashSet<>(); | ||
|
|
||
| for(int i=0; i< 100000 ; ++i) { |
There was a problem hiding this comment.
seems that this line need to be reformatted
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #7583 +/- ##
=============================================
+ Coverage 43.17% 43.21% +0.04%
- Complexity 9780 9787 +7
=============================================
Files 1162 1162
Lines 84303 84378 +75
Branches 10949 10955 +6
=============================================
+ Hits 36396 36466 +70
+ Misses 43386 43382 -4
- Partials 4521 4530 +9 ☔ View full report in Codecov by Sentry. |
RongtongJin
reviewed
Nov 30, 2023
Comment on lines
137
to
154
| @Test | ||
| public void hugeTopicListAddTest() { | ||
| Set<String> mapSet = ConcurrentHashMap.newKeySet(); | ||
| Set<String> copyOnWriteArraySet = new CopyOnWriteArraySet<>(); | ||
| HashSet<String> topics = new HashSet<>(); | ||
|
|
||
| for (int i = 0; i < 100000; ++i) { | ||
| topics.add("Topic" + i); | ||
| } | ||
| long startTime = System.currentTimeMillis(); | ||
| mapSet.addAll(topics); | ||
| long endTime = System.currentTimeMillis(); | ||
| assertThat(endTime - startTime < 100).isTrue(); | ||
| startTime = System.currentTimeMillis(); | ||
| copyOnWriteArraySet.addAll(topics); | ||
| endTime = System.currentTimeMillis(); | ||
| assertThat(endTime - startTime > 3000).isTrue(); | ||
| } |
There was a problem hiding this comment.
It seems that this test is unnecessary
RongtongJin
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7534