[RIP-46] Enhanced metrics for timing and transactional messages #7500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #7500 +/- ##
=============================================
+ Coverage 42.53% 43.01% +0.47%
- Complexity 9441 9698 +257
=============================================
Files 1150 1160 +10
Lines 82746 84219 +1473
Branches 10778 10936 +158
=============================================
+ Hits 35196 36226 +1030
- Misses 43139 43499 +360
- Partials 4411 4494 +83
... and 118 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
joeCarf
approved these changes
Oct 27, 2023
| @@ -18,7 +18,6 @@ | |||
|
|
|||
| public class RemotingMetricsConstant { | |||
| public static final String HISTOGRAM_RPC_LATENCY = "rocketmq_rpc_latency"; | |||
|
|
|||
There was a problem hiding this comment.
no need to change this line
| @@ -65,10 +43,35 @@ | |||
| import org.apache.rocketmq.store.config.BrokerRole; | |||
| import org.apache.rocketmq.store.config.MessageStoreConfig; | |||
| import org.apache.rocketmq.store.logfile.MappedFile; | |||
| import org.apache.rocketmq.store.metrics.DefaultStoreMetricsConstant; | |||
There was a problem hiding this comment.
too many import changes, and most are not needed
joeCarf
approved these changes
Nov 16, 2023
RongtongJin
approved these changes
Jan 22, 2024
|
LGTM～ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Some enhanced metrics of RIP-46, link to #5350
Brief Description
The following metrics related to timing messages have been added:
rocketmq_timing_end_messages_total, COUNTER, records the number of timing messages that have ended, aggregated by topic.rocketmq_delay_message_latency, HISTOGRAM, records the distribution of timing message delay durations when sent, aggregated by topic.rocketmq_timer_message_snapshot, GUAGE, records the distribution of timing messages in the timing wheel (right now). Not aggregated by topic.The following metrics related to transactional messages have been added:
rocketmq_half_messages, GAUGE, records the number of half messages in transactional scenarios, aggregated by topic.rocketmq_commit_messages_total, COUNTER, records the number of messages committed in transactions, aggregated by topic.rocketmq_rollback_messages_total, COUNTER, records the number of messages rolled back in transactions, aggregated by topic.rocketmq_transaction_finish_latency, HISTOGRAM, records the distribution of delay times for committing transactional half messages, aggregated by topic.In addition, to calculate metrics related to transactional messages, a new data structure called TransactionMetrics has been added to record the number of transactional half messages under each topic.
How Did You Test This Change?
I will provide a test report later.