Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7493] Introduce a new event NettyEventType.ACTIVE #7494

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

drpmma
Copy link
Contributor

@drpmma drpmma commented Oct 23, 2023

  • introduce a new event NettyEventType.ACTIVE,

  • implement channelActive interface for NettyRemotingClient#NettyConnectManageHandler

  • add onChannelActive for ChannelEventListener interface.

Which Issue(s) This PR Fixes

Fixes #7493

Brief Description

Introduce a new event NettyEventType.ACTIVE for ChannelEventListener

How Did You Test This Change?

…hannelEventListener

* introduce a new event NettyEventType.ACTIVE,

* implement channelActive interface for NettyRemotingClient#NettyConnectManageHandler

* add onChannelActive for ChannelEventListener interface.
@codecov-commenter
Copy link

Codecov Report

Merging #7494 (d1922de) into develop (f0f15b5) will increase coverage by 0.05%.
Report is 3 commits behind head on develop.
The diff coverage is 22.22%.

@@              Coverage Diff              @@
##             develop    #7494      +/-   ##
=============================================
+ Coverage      42.93%   42.99%   +0.05%     
- Complexity      9660     9676      +16     
=============================================
  Files           1161     1161              
  Lines          83930    83950      +20     
  Branches       10898    10899       +1     
=============================================
+ Hits           36038    36094      +56     
+ Misses         43410    43385      -25     
+ Partials        4482     4471      -11     
Files Coverage Δ
...apache/rocketmq/remoting/netty/NettyEventType.java 100.00% <100.00%> (ø)
...che/rocketmq/acl/plain/PlainPermissionManager.java 78.37% <0.00%> (ø)
...ketmq/broker/client/ClientHousekeepingService.java 30.30% <0.00%> (-0.95%) ⬇️
...rocketmq/controller/BrokerHousekeepingService.java 58.33% <0.00%> (-5.31%) ⬇️
...q/namesrv/routeinfo/BrokerHousekeepingService.java 63.63% <0.00%> (-6.37%) ⬇️
...etmq/proxy/remoting/ClientHousekeepingService.java 0.00% <0.00%> (ø)
...rocketmq/remoting/netty/NettyRemotingAbstract.java 56.80% <0.00%> (-0.34%) ⬇️
...e/rocketmq/remoting/netty/NettyRemotingClient.java 40.55% <66.66%> (+0.25%) ⬆️
.../container/ContainerClientHouseKeepingService.java 7.14% <0.00%> (-0.55%) ⬇️
...rocketmq/client/impl/factory/MQClientInstance.java 43.89% <0.00%> (-0.07%) ⬇️

... and 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@drpmma drpmma merged commit 2043dd5 into apache:develop Oct 24, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Introduce a new event NettyEventType.ACTIVE for ChannelEventListener
3 participants