[ISSUE #7454] Utilizing cache to avoid duplicate parsing #7455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about add a method argument to decide cacheable？🤔️ |
joeCarf
reviewed
Oct 13, 2023
| @@ -260,7 +261,11 @@ public void writeCustomHeader(CommandCustomHeader customHeader) { | |||
|
|
|||
| public CommandCustomHeader decodeCommandCustomHeader( | |||
| Class<? extends CommandCustomHeader> classHeader) throws RemotingCommandException { | |||
| return decodeCommandCustomHeader(classHeader, true); | |||
| if (cachedHeader != null) { | |||
There was a problem hiding this comment.
对于两次不同的入参，这种写法会出现返回结果相同的情况。符合预期吗
|
have changed |
RongtongJin
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7454
Brief Description
How Did You Test This Change?