[ISSUE #7444] Fix testCalculateFileSizeInPath test can not rerun in same environment #7445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeCarf
reviewed
Oct 11, 2023
| @@ -271,8 +271,19 @@ public void testCalculateFileSizeInPath() throws Exception { | |||
|
|
|||
| assertEquals(1313 * 4, UtilAll.calculateFileSizeInPath(baseFile)); | |||
|
|
|||
| // clear all file | |||
| baseFile.deleteOnExit(); | |||
| deleteFolder(baseFile); | |||
There was a problem hiding this comment.
如果某次fail了，是不是就无法执行到删除逻辑。放在test开始前，每次执行先删除会不会更好
Codecov Report
@@ Coverage Diff @@
## develop #7445 +/- ##
=============================================
+ Coverage 42.68% 42.71% +0.02%
- Complexity 9477 9487 +10
=============================================
Files 1150 1150
Lines 82814 82825 +11
Branches 10768 10771 +3
=============================================
+ Hits 35346 35375 +29
+ Misses 43045 43029 -16
+ Partials 4423 4421 -2
... and 19 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ShannonDing
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7444
Brief Description
Fix testCalculateFileSizeInPath test can not rerun in same environment
How Did You Test This Change?