[ISSUE 7313] Enhancement Optimization Method name #7420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeCarf
reviewed
Oct 1, 2023
shriVATSA54
changed the title
shriVATSA54
changed the title
As per your request I have made changes in Title. |
|
|
joeCarf
reviewed
Oct 2, 2023
shriVATSA54
changed the title
Oh Sorry! Made changes once again. |
Will it be merged ?? Should I keep contributing to some other issues too? |
Wait for a committer or PMC to merge the code |
RongtongJin
approved these changes
Oct 7, 2023
Codecov Report
@@ Coverage Diff @@
## develop #7420 +/- ##
=============================================
- Coverage 42.62% 42.61% -0.01%
+ Complexity 9466 9465 -1
=============================================
Files 1150 1150
Lines 82758 82758
Branches 10779 10779
=============================================
- Hits 35272 35271 -1
- Misses 43062 43072 +10
+ Partials 4424 4415 -9
... and 23 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue=> #7313
#7313 This is link for my issue.
Fixes #7313
Brief Description
There was an Enhancement change needed to change method name from addTopicToWhiteList of this TieredStoreTopicBlackListFilter class should be renamed to addTopicToBlackList .
In three places it was required to change the name which I have done.
Note: This was my first ever contributions if you need some changes or if I committed mistake please do say and give feedback
How Did You Test This Change?
I have tried running the file and are running.