-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #7330] Add goaway and reconnection mechanism #7331
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drpmma
force-pushed
the
feature/go-away-sub-task
branch
from
September 8, 2023 08:49
48e5d18
to
b33c915
Compare
drpmma
force-pushed
the
feature/go-away-sub-task
branch
from
October 8, 2023 09:51
f26c8d5
to
2f5a95c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #7331 +/- ##
=============================================
- Coverage 42.70% 42.67% -0.03%
+ Complexity 9480 9478 -2
=============================================
Files 1150 1150
Lines 82687 82814 +127
Branches 10749 10768 +19
=============================================
+ Hits 35311 35344 +33
- Misses 42973 43050 +77
- Partials 4403 4420 +17
... and 25 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xdkxlk
reviewed
Oct 9, 2023
remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java
Outdated
Show resolved
Hide resolved
RongtongJin
previously approved these changes
Oct 10, 2023
…rLifecycleListener (apache#7432) * Fix flaky test of DLedgerControllerTest#testBrokerLifecycleListener
RongtongJin
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7330
Brief Description
Add
goaway
response code when the server is shutting down and client reconnection and transparent retry mechanism.How Did You Test This Change?
Existing unit test.