Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7166] Optimize the display format of admin #7210

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

yx9o
Copy link
Contributor

@yx9o yx9o commented Aug 18, 2023

Fixes #7166, optimize the display format of admin.

@codecov-commenter
Copy link

Codecov Report

Merging #7210 (313d357) into develop (72d796f) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #7210      +/-   ##
=============================================
- Coverage      42.46%   42.43%   -0.04%     
+ Complexity      9353     9347       -6     
=============================================
  Files           1149     1149              
  Lines          82111    82111              
  Branches       10703    10703              
=============================================
- Hits           34868    34843      -25     
- Misses         42882    42899      +17     
- Partials        4361     4369       +8     
Files Changed Coverage Δ
.../apache/rocketmq/tools/command/MQAdminStartup.java 0.00% <0.00%> (ø)
...and/acl/ClusterAclConfigVersionListSubCommand.java 20.40% <0.00%> (ø)
...ools/command/acl/DeleteAccessConfigSubCommand.java 31.70% <0.00%> (ø)
...q/tools/command/acl/GetAccessConfigSubCommand.java 19.60% <0.00%> (ø)
...ools/command/acl/UpdateAccessConfigSubCommand.java 39.53% <0.00%> (ø)
...s/command/acl/UpdateGlobalWhiteAddrSubCommand.java 36.36% <0.00%> (ø)
...ls/command/broker/BrokerConsumeStatsSubCommad.java 40.27% <0.00%> (ø)
...q/tools/command/broker/BrokerStatusSubCommand.java 50.00% <0.00%> (ø)
...ommand/broker/CommitLogSetReadAheadSubCommand.java 0.00% <0.00%> (ø)
...mmand/broker/DeleteExpiredCommitLogSubCommand.java 65.62% <0.00%> (ø)
... and 49 more

... and 39 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@joeCarf joeCarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RongtongJin
Copy link
Contributor

LGTM

@RongtongJin RongtongJin merged commit fec1414 into apache:develop Aug 23, 2023
10 checks passed
@yx9o yx9o deleted the dev-7166 branch August 23, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Optimize the display format of admin
4 participants