Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7144] Accelerate the recovery speed of the tiered storage module #7145

Merged

Conversation

lizhimins
Copy link
Member

Which Issue(s) This PR Fixes

Fixes #7144

Brief Description

How Did You Test This Change?

@lizhimins lizhimins changed the title [Enhancement] Accelerate the recovery speed of the tiered storage module [ISSUE #7144] Accelerate the recovery speed of the tiered storage module Aug 9, 2023
drpmma
drpmma previously approved these changes Aug 9, 2023
Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Merging #7145 (540f462) into develop (1fe5d62) will decrease coverage by 0.61%.
Report is 5 commits behind head on develop.
The diff coverage is 27.91%.

@@              Coverage Diff              @@
##             develop    #7145      +/-   ##
=============================================
- Coverage      42.74%   42.14%   -0.61%     
+ Complexity      9309     9255      -54     
=============================================
  Files           1138     1149      +11     
  Lines          81272    82033     +761     
  Branches       10639    10698      +59     
=============================================
- Hits           34738    34569     -169     
- Misses         42197    43114     +917     
- Partials        4337     4350      +13     
Files Changed Coverage Δ
...broker/offset/RocksDBLmqConsumerOffsetManager.java 0.00% <0.00%> (ø)
...bscription/RocksDBLmqSubscriptionGroupManager.java 0.00% <0.00%> (ø)
...tmq/broker/topic/RocksDBLmqTopicConfigManager.java 0.00% <0.00%> (ø)
...java/org/apache/rocketmq/common/ConfigManager.java 56.41% <0.00%> (-3.05%) ⬇️
...rocketmq/common/config/AbstractRocksDBStorage.java 0.00% <0.00%> (ø)
...e/rocketmq/common/config/ConfigRocksDBStorage.java 0.00% <0.00%> (ø)
...e/rocketmq/common/config/RocksDBConfigManager.java 0.00% <0.00%> (ø)
...rg/apache/rocketmq/common/constant/LoggerName.java 0.00% <ø> (ø)
...or/validator/DefaultTopicMessageTypeValidator.java 33.33% <0.00%> (-6.67%) ⬇️
...pache/rocketmq/tieredstore/TieredMessageStore.java 73.70% <0.00%> (ø)
... and 21 more

... and 39 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lollipopjin lollipopjin merged commit b2deef1 into apache:develop Aug 10, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Accelerate the recovery speed of the tiered storage module
4 participants