[ISSUE #7129] fix resource collisions in acl tests #7130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #7130 +/- ##
=============================================
+ Coverage 42.13% 42.45% +0.31%
- Complexity 9258 9341 +83
=============================================
Files 1149 1149
Lines 82000 82000
Branches 10694 10694
=============================================
+ Hits 34550 34811 +261
+ Misses 43100 42823 -277
- Partials 4350 4366 +16 see 26 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
RongtongJin
approved these changes
Aug 10, 2023
RongtongJin
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7129
Brief Description
Some test cases of rocketmq-acl change system property to set their own configurations, but make them not run in parallel. This 'fix' just disable the parallel execution at runtime to pass related workflows, and further refactoring is needed to support separation contexts of different test cases.
How Did You Test This Change?