Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7029] Add a config to determine whether pop response should return the actual retry topic or tamper with the original topic #7030

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

RongtongJin
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #7029

Brief Description

Add a config to determine whether pop response should return the actual retry topic or tamper with the original topic

How Did You Test This Change?

…al retry topic or tamper with the original topic
@codecov-commenter
Copy link

Codecov Report

Merging #7030 (d43813a) into develop (5914ff8) will increase coverage by 0.00%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##             develop    #7030   +/-   ##
==========================================
  Coverage      42.64%   42.65%           
- Complexity      9234     9241    +7     
==========================================
  Files           1136     1136           
  Lines          80646    80650    +4     
  Branches       10539    10539           
==========================================
+ Hits           34393    34398    +5     
  Misses         41962    41962           
+ Partials        4291     4290    -1     
Impacted Files Coverage Δ
...rocketmq/broker/processor/PopMessageProcessor.java 45.56% <0.00%> (+0.61%) ⬆️
.../java/org/apache/rocketmq/common/BrokerConfig.java 27.28% <25.00%> (-0.02%) ⬇️

... and 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lizhimins lizhimins merged commit 737c1e5 into apache:develop Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants