-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #6968] fix grpc acl bug #6969
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #6969 +/- ##
=============================================
- Coverage 42.65% 42.62% -0.03%
- Complexity 9234 9235 +1
=============================================
Files 1136 1136
Lines 80635 80644 +9
Branches 10538 10539 +1
=============================================
- Hits 34393 34377 -16
- Misses 41938 41976 +38
+ Partials 4304 4291 -13
... and 39 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but maybe adding some unit tests would be better.
ok I will add some necessary to prove this |
@lyx2000 Some check not pass, can you rerun the tests? |
Ok, please wait for me for a few days, I will add some unit tests that can reflect the problem. 💪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6c1112e
to
02ed4c7
Compare
When writing the unit tests, I found that there wasn't a test complete with a joint test from parsing the request to checking the permissions, so I added tests related to both protocol clients. These additional tests would not have passed before my fix. |
Signed-off-by: lyx <[email protected]> # Conflicts: # proxy/src/main/java/org/apache/rocketmq/proxy/grpc/GrpcServerBuilder.java
Signed-off-by: lyx <[email protected]>
Signed-off-by: lyx <[email protected]>
Signed-off-by: lyx <[email protected]>
Signed-off-by: lyx <[email protected]>
89f13fc
to
c642134
Compare
Which Issue(s) This PR Fixes
Fixes #6968
Brief Description
As issue mentioned.
How Did You Test This Change?
The failure examples mentioned in the issue have been successfully accessed, then I will add enough unit tests like remoting as soon as possible.