[ISSUE #6917] fix cannot query all messages of the same msgId #6918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RongtongJin
reviewed
Jun 20, 2023
Comment on lines
-416
to
-420
| if (messageList.get(0).getStoreTimestamp() > msgExt.getStoreTimestamp()) { | ||
|
|
||
| messageList.clear(); | ||
| messageList.add(msgExt); | ||
| } |
There was a problem hiding this comment.
If only one is to be kept, do we need to retain the original semantics and ensure that the storeTimestamp is the greatest for this one to be kept?
There was a problem hiding this comment.
Actually, A consumer that achieves idempotence only takes the first message, and ignores others. So I think it's not appropriate to keep the last message.
RongtongJin
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #6917
Brief Description
How Did You Test This Change?