Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6797]Support batch ack when reput buffer ak to store in PopBufferMergeService #6798

Merged
merged 3 commits into from
May 24, 2023

Conversation

DongyuanPan
Copy link
Contributor

@DongyuanPan DongyuanPan commented May 23, 2023

Which Issue(s) This PR Fixes

Fixes #6797

Brief Description

see ISSUE #6797

@DongyuanPan DongyuanPan changed the title [ISSUE #6795]Support batch ack when reput buffer ak to store in PopBufferMergeService [ISSUE #6798]Support batch ack when reput buffer ak to store in PopBufferMergeService May 23, 2023
@DongyuanPan DongyuanPan changed the title [ISSUE #6798]Support batch ack when reput buffer ak to store in PopBufferMergeService [ISSUE #6797]Support batch ack when reput buffer ak to store in PopBufferMergeService May 23, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #6798 (aad1f61) into develop (c5fec3a) will decrease coverage by 0.22%.
The diff coverage is 43.84%.

@@              Coverage Diff              @@
##             develop    #6798      +/-   ##
=============================================
- Coverage      43.08%   42.86%   -0.22%     
- Complexity      8920     8984      +64     
=============================================
  Files           1105     1105              
  Lines          78002    78471     +469     
  Branches       10151    10227      +76     
=============================================
+ Hits           33604    33638      +34     
- Misses         40180    40615     +435     
  Partials        4218     4218              
Impacted Files Coverage Δ
...a/org/apache/rocketmq/common/ControllerConfig.java 0.00% <0.00%> (ø)
...va/org/apache/rocketmq/common/PopAckConstants.java 0.00% <ø> (ø)
.../impl/heartbeat/DefaultBrokerHeartbeatManager.java 82.27% <ø> (ø)
...cketmq/broker/processor/PopBufferMergeService.java 30.29% <1.92%> (-3.04%) ⬇️
.../java/org/apache/rocketmq/common/BrokerConfig.java 27.97% <25.00%> (+0.01%) ⬆️
...ava/org/apache/rocketmq/store/pop/BatchAckMsg.java 33.33% <33.33%> (ø)
...he/rocketmq/broker/processor/PopReviveService.java 36.47% <35.48%> (-1.70%) ⬇️
...tmq/controller/impl/manager/BrokerReplicaInfo.java 61.11% <45.45%> (-9.86%) ⬇️
.../apache/rocketmq/controller/ControllerManager.java 49.66% <53.84%> (+1.46%) ⬆️
...he/rocketmq/controller/impl/DLedgerController.java 71.68% <79.31%> (+5.02%) ⬆️
... and 3 more

... and 139 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RongtongJin
Copy link
Contributor

LGTM~

@ShannonDing ShannonDing merged commit 985319b into apache:develop May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Support batch ack when reput buffer ak to store in PopBufferMergeService
4 participants