[ISSUE #6785] Isolate the remoteChannel by group #6786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #6786 +/- ##
=============================================
+ Coverage 42.84% 42.89% +0.05%
- Complexity 8976 8987 +11
=============================================
Files 1108 1104 -4
Lines 78444 78376 -68
Branches 10212 10203 -9
=============================================
+ Hits 33607 33620 +13
+ Misses 40617 40542 -75
+ Partials 4220 4214 -6
... and 23 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chenzlalvin
reviewed
May 23, 2023
| @@ -49,7 +49,7 @@ public class HeartbeatSyncer extends AbstractSystemMessageSyncer { | |||
|
|
|||
| protected ThreadPoolExecutor threadPoolExecutor; | |||
| protected ConsumerManager consumerManager; | |||
| protected final Map<String /* channelId as longText */, RemoteChannel> remoteChannelMap = new ConcurrentHashMap<>(); | |||
| protected final Map<String /* group @ channelId as longText */, RemoteChannel> remoteChannelMap = new ConcurrentHashMap<>(); | |||
There was a problem hiding this comment.
Will the "@" symbol conflict with the Group character?
There was a problem hiding this comment.
This is not a problem, as long as clients from different groups can be distinguished here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #6785
Brief Description
How Did You Test This Change?