[ISSUE #6633] [RIP-65] Improving Tiered Storage Implementation #6781
Conversation
tieredstore/src/main/java/org/apache/rocketmq/tieredstore/TieredDispatcher.java
Outdated
Show resolved
Hide resolved
|
Later I will fix unit test in Windows |
tieredstore/src/main/java/org/apache/rocketmq/tieredstore/provider/posix/PosixFileSegment.java
Outdated
Show resolved
Hide resolved
| interface CompositeAccess { | ||
|
|
||
| /** | ||
| * Initializes the offset for the flat file. |
There was a problem hiding this comment.
Since we have extracted CompositeAccess from CompositeQueueFlatFile, could we replace the CompositeQueueFlatFile with CompositeAccess to avoid exposing some details? such as the return value of TieredFlatFileManager#deepCopyFlatFileToList.
There was a problem hiding this comment.
In current model, cq entered the flat file buffer after commitlog dispatch done, so it is necessary to separate two parts here
Codecov Report
@@ Coverage Diff @@
## develop #6781 +/- ##
=============================================
+ Coverage 42.44% 42.69% +0.24%
- Complexity 9105 9107 +2
=============================================
Files 1125 1125
Lines 80258 79879 -379
Branches 10453 10380 -73
=============================================
+ Hits 34064 34101 +37
+ Misses 41903 41504 -399
+ Partials 4291 4274 -17
... and 18 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -65,13 +66,13 @@ public class TieredMessageFetcher { | |||
| private final TieredMessageStoreConfig storeConfig; | |||
| private final String brokerName; | |||
| private TieredMetadataStore metadataStore; | |||
| private final TieredContainerManager containerManager; | |||
| private final TieredFlatFileManager containerManager; | |||
lizhimins
force-pushed
the
new-tiered-storage
branch
from
0101fdc
to
afbaed1
Compare
lizhimins
force-pushed
the
new-tiered-storage
branch
from
d08041f
to
df58a43
Compare
According to the plan proposed in RIP-65, the improvements in this submission involve bugfixes and metadata management API, but will not "break data format compatibility".