Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6779] Support scheduled message for LMQ #6780

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

HScarb
Copy link
Contributor

@HScarb HScarb commented May 21, 2023

Which Issue(s) This PR Fixes

Fixes #6779

Brief Description

Don't dispatch message to LMQ when the message is scheduled message.

How Did You Test This Change?

  1. Start a consumer to consume a LMQ
  2. Send a message with delay level or delay time
  3. The message consumed at scheduled time

@codecov-commenter
Copy link

Codecov Report

Merging #6780 (e8f5f96) into develop (bd7db7e) will increase coverage by 0.02%.
The diff coverage is 25.00%.

@@              Coverage Diff              @@
##             develop    #6780      +/-   ##
=============================================
+ Coverage      42.92%   42.95%   +0.02%     
- Complexity      8985     8991       +6     
=============================================
  Files           1104     1104              
  Lines          78376    78382       +6     
  Branches       10203    10209       +6     
=============================================
+ Hits           33645    33666      +21     
+ Misses         40512    40497      -15     
  Partials        4219     4219              
Impacted Files Coverage Δ
...n/java/org/apache/rocketmq/store/ConsumeQueue.java 65.99% <25.00%> (-0.31%) ⬇️

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@pingww pingww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link
Contributor

@DongyuanPan DongyuanPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RongtongJin RongtongJin merged commit 1d62b74 into apache:develop Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] LMQ did not support scheduled message
6 participants