Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6761] Support reentrant notification orderly for broker #6762

Merged
merged 1 commit into from
May 16, 2023

Conversation

xdkxlk
Copy link
Contributor

@xdkxlk xdkxlk commented May 15, 2023

Which Issue(s) This PR Fixes

Fixes #6761

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link

Codecov Report

Merging #6762 (58f57d3) into develop (5dc2e20) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #6762      +/-   ##
=============================================
- Coverage      42.89%   42.84%   -0.05%     
+ Complexity      9009     8981      -28     
=============================================
  Files           1113     1108       -5     
  Lines          78603    78439     -164     
  Branches       10226    10210      -16     
=============================================
- Hits           33713    33610     -103     
+ Misses         40670    40616      -54     
+ Partials        4220     4213       -7     
Impacted Files Coverage Δ
...cketmq/broker/processor/NotificationProcessor.java 7.07% <0.00%> (-0.08%) ⬇️
...ing/protocol/header/NotificationRequestHeader.java 0.00% <0.00%> (ø)
.../apache/rocketmq/test/client/rmq/RMQPopClient.java 0.00% <0.00%> (ø)

... and 42 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xdkxlk xdkxlk merged commit 9dfd4a9 into apache:develop May 16, 2023
@xdkxlk xdkxlk deleted the develop-notification branch May 16, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support reentrant notification orderly for broker
3 participants