-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #6624]Support mark() & reset() for TieredFileSegmentInputStream #6625
Merged
zhouxinyu
merged 13 commits into
apache:develop
from
TheR1sing3un:support_reset_method_of_TieredFileSegmentInputStream
May 31, 2023
Merged
[ISSUE #6624]Support mark() & reset() for TieredFileSegmentInputStream #6625
zhouxinyu
merged 13 commits into
apache:develop
from
TheR1sing3un:support_reset_method_of_TieredFileSegmentInputStream
May 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. add UT to verify TieredFileSegmentInputStream
1. refactor TieredFileSegmentInputStream
1. support mark&reset TieredFileSegmentInputStream
…StreamTest 1. remove commended code in TieredFileSegmentInputStreamTest
1. better code placement
TheR1sing3un
changed the title
[ISSUE #6624]Support reset method of tiered file segment input stream
[ISSUE #6624]Support mark() & reset() for TieredFileSegmentInputStream
Apr 20, 2023
tieredstore/src/main/java/org/apache/rocketmq/tieredstore/provider/TieredFileSegment.java
Outdated
Show resolved
Hide resolved
tieredstore/src/main/java/org/apache/rocketmq/tieredstore/provider/TieredFileSegment.java
Outdated
Show resolved
Hide resolved
tieredstore/src/main/java/org/apache/rocketmq/tieredstore/provider/TieredFileSegment.java
Outdated
Show resolved
Hide resolved
…tter understandability 1. refactor TieredFileSegmentInputStream for better understandability
...ore/src/main/java/org/apache/rocketmq/tieredstore/provider/TieredFileSegmentInputStream.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/org/apache/rocketmq/tieredstore/provider/TieredFileSegmentInputStream.java
Outdated
Show resolved
Hide resolved
…Stream 1. refactor some code in TieredFileSegmentInputStream
Codecov Report
@@ Coverage Diff @@
## develop #6625 +/- ##
==========================================
Coverage 43.11% 43.12%
- Complexity 8997 9001 +4
==========================================
Files 1107 1108 +1
Lines 78287 78367 +80
Branches 10202 10212 +10
==========================================
+ Hits 33755 33792 +37
- Misses 40314 40339 +25
- Partials 4218 4236 +18
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
1. refactor TieredFileSegmentInputStream 2. add a TieredFileSegmentInputStream.Factory to build instance
…d directory structure 1. refactor TieredFileSegmentInputStream related directory structure
zhouxinyu
reviewed
Apr 25, 2023
...in/java/org/apache/rocketmq/tieredstore/provider/inputstream/TieredCommitLogInputStream.java
Outdated
Show resolved
Hide resolved
zhouxinyu
reviewed
Apr 25, 2023
.../java/org/apache/rocketmq/tieredstore/provider/inputstream/TieredFileSegmentInputStream.java
Show resolved
Hide resolved
…itLogInputStream 1. delete `commitLogOffsetBuffer` in TieredCommitLogInputStream
1. benchmark TieredFileSegmentInputStream pef Closes apache#6624
…eSegmentInputStream 1. optimized `read(byte[], int, int)` for TieredFIleSegmentInputStream Closes apache#6624
1. fix a dead cycle in TieredFileSegmentInputStream.java 2. remove unused JMH related dependency Closes apache#6624
ShadowySpirits
approved these changes
May 30, 2023
zhouxinyu
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure set the target branch to
develop
What is the purpose of the change
fix #6624
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.