-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #6346] Support asynchronously notify brokers when their roles has been changed #6348
Merged
RongtongJin
merged 2 commits into
apache:develop
from
TheR1sing3un:fix_synchronous_call_notifyBrokerRoleChanged
Mar 15, 2023
Merged
[ISSUE #6346] Support asynchronously notify brokers when their roles has been changed #6348
RongtongJin
merged 2 commits into
apache:develop
from
TheR1sing3un:fix_synchronous_call_notifyBrokerRoleChanged
Mar 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. support asynchronous notify brokers when roles changed
TheR1sing3un
changed the title
ISSUE[# 6346] support asynchronously notify brokers when their roles has been changed
ISSUE[ #6346] support asynchronously notify brokers when their roles has been changed
Mar 14, 2023
RongtongJin
changed the title
ISSUE[ #6346] support asynchronously notify brokers when their roles has been changed
[ISSUE #6346] support asynchronously notify brokers when their roles has been changed
Mar 14, 2023
RongtongJin
changed the title
[ISSUE #6346] support asynchronously notify brokers when their roles has been changed
[ISSUE #6346] Support asynchronously notify brokers when their roles has been changed
Mar 14, 2023
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6348 +/- ##
=============================================
- Coverage 43.01% 43.00% -0.02%
- Complexity 8892 8895 +3
=============================================
Files 1103 1103
Lines 77763 77839 +76
Branches 10126 10134 +8
=============================================
+ Hits 33453 33477 +24
- Misses 40118 40168 +50
- Partials 4192 4194 +2 ☔ View full report in Codecov by Sentry. |
RongtongJin
previously approved these changes
Mar 14, 2023
RongtongJin
reviewed
Mar 14, 2023
controller/src/main/java/org/apache/rocketmq/controller/ControllerManager.java
Show resolved
Hide resolved
…ontrollerManager's constructor method 1. move creating NotifyService instance logic to ControllerManager's constructor method
RongtongJin
approved these changes
Mar 15, 2023
miles-ton
pushed a commit
to miles-ton/rocketmq
that referenced
this pull request
Mar 16, 2023
…roles has been changed (apache#6348) * feat(controller): support asynchronous notify brokers when roles changed 1. support asynchronous notify brokers when roles changed * refactor(controller): move creating NotifyService instance logic to ControllerManager's constructor method 1. move creating NotifyService instance logic to ControllerManager's constructor method
fuyou001
pushed a commit
to fuyou001/rocketmq
that referenced
this pull request
Mar 16, 2023
…roles has been changed (apache#6348) * feat(controller): support asynchronous notify brokers when roles changed 1. support asynchronous notify brokers when roles changed * refactor(controller): move creating NotifyService instance logic to ControllerManager's constructor method 1. move creating NotifyService instance logic to ControllerManager's constructor method
TheR1sing3un
added a commit
to TheR1sing3un/rocketmq
that referenced
this pull request
Mar 17, 2023
…roles has been changed (apache#6348) * feat(controller): support asynchronous notify brokers when roles changed 1. support asynchronous notify brokers when roles changed * refactor(controller): move creating NotifyService instance logic to ControllerManager's constructor method 1. move creating NotifyService instance logic to ControllerManager's constructor method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure set the target branch to
develop
What is the purpose of the change
fix #6346
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.