Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6333]Simplify the logic of the FilterAPI#buildSubscriptionData method #6334

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

mxsm
Copy link
Member

@mxsm mxsm commented Mar 13, 2023

Make sure set the target branch to develop

What is the purpose of the change

fix #6333

Brief changelog

  • Simplify the logic of the FilterAPI#buildSubscriptionData method
  • remove some useless method

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@RongtongJin RongtongJin merged commit 22a7ec6 into apache:develop Mar 14, 2023
@mxsm mxsm deleted the rocketmq-6333 branch March 14, 2023 03:40
miles-ton pushed a commit to miles-ton/rocketmq that referenced this pull request Mar 16, 2023
fuyou001 pushed a commit to fuyou001/rocketmq that referenced this pull request Mar 16, 2023
TheR1sing3un pushed a commit to TheR1sing3un/rocketmq that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify the logic of the FilterAPI#buildSubscriptionData method
4 participants