Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6213] fix: when subscriptionGroupConfig is null ,we do not register consumer #6214

Merged
merged 1 commit into from
Mar 8, 2023
Merged

[ISSUE #6213] fix: when subscriptionGroupConfig is null ,we do not register consumer #6214

merged 1 commit into from
Mar 8, 2023

Conversation

leizhiyuan
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

fix #6213

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #6214 (50df11e) into develop (88000da) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #6214      +/-   ##
=============================================
+ Coverage      43.18%   43.22%   +0.03%     
- Complexity      8848     8858      +10     
=============================================
  Files           1094     1094              
  Lines          77184    77185       +1     
  Branches       10070    10071       +1     
=============================================
+ Hits           33332    33362      +30     
+ Misses         39682    39654      -28     
+ Partials        4170     4169       -1     
Impacted Files Coverage Δ
...cketmq/broker/processor/ClientManageProcessor.java 26.47% <0.00%> (-0.27%) ⬇️
...he/rocketmq/broker/controller/ReplicasManager.java 44.40% <0.00%> (-2.62%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 82.21% <0.00%> (-1.45%) ⬇️
...mq/store/ha/autoswitch/AutoSwitchHAConnection.java 70.27% <0.00%> (-1.36%) ⬇️
.../org/apache/rocketmq/store/ha/DefaultHAClient.java 60.82% <0.00%> (-0.52%) ⬇️
...ketmq/store/ha/autoswitch/AutoSwitchHAService.java 54.95% <0.00%> (-0.46%) ⬇️
...rocketmq/client/impl/factory/MQClientInstance.java 46.82% <0.00%> (-0.15%) ⬇️
...va/org/apache/rocketmq/store/FlushDiskWatcher.java 81.25% <0.00%> (ø)
...cketmq/store/ha/autoswitch/AutoSwitchHAClient.java 76.53% <0.00%> (+0.36%) ⬆️
...a/org/apache/rocketmq/store/StoreStatsService.java 35.63% <0.00%> (+1.10%) ⬆️
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@drpmma drpmma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drpmma drpmma merged commit 61c4ba5 into apache:develop Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when set autoCreateSubscriptionGroup false,consumerTable still add the group
3 participants