[ISSUE #6121] Optimize some code style in store module #6122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. optimize some typos in store module
Codecov Report
@@ Coverage Diff @@
## develop #6122 +/- ##
=============================================
+ Coverage 43.22% 43.24% +0.01%
- Complexity 8846 8851 +5
=============================================
Files 1094 1094
Lines 77137 77135 -2
Branches 10057 10057
=============================================
+ Hits 33346 33356 +10
+ Misses 39628 39615 -13
- Partials 4163 4164 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
RongtongJin
previously approved these changes
Feb 20, 2023
store/src/main/java/org/apache/rocketmq/store/ha/DefaultHAClient.java
Outdated
Show resolved
Hide resolved
…#REPORT_HEADER_SIZE 1. rename DefaultHAClient#REPORT_HEADER to DefaultHAClient#REPORT_HEADER_SIZE
mxsm
suggested changes
Feb 20, 2023
There was a problem hiding this comment.
Hi @TheR1sing3un reference AutoSwitchHAConnection class comments
store/src/main/java/org/apache/rocketmq/store/ha/DefaultHAConnection.java
Outdated
Show resolved
Hide resolved
store/src/main/java/org/apache/rocketmq/store/ha/DefaultHAClient.java
Outdated
Show resolved
Hide resolved
…ZE and DefaultHAConnection#TRANSFER_HEADER_SIZE 1. optimize comment about DefaultHAClient#REPORT_HEADER_SIZE and DefaultHAConnection#TRANSFER_HEADER_SIZE
Oliverwqcwrw
approved these changes
Feb 24, 2023
hzh0425
approved these changes
Feb 24, 2023
RongtongJin
changed the title
|
Hi @TheR1sing3un, plz merge the latest develop branch to pass CI. |
RongtongJin
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #6121
Make sure set the target branch to
developWhat is the purpose of the change
fix #
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.