Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6112] Fix typos in RemoteAddressStrategyFactory #6113

Merged
merged 1 commit into from
Feb 19, 2023
Merged

[ISSUE #6112] Fix typos in RemoteAddressStrategyFactory #6113

merged 1 commit into from
Feb 19, 2023

Conversation

hardyfish
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

close #6112

Brief changelog

fix typos

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #6113 (d9bc56e) into develop (975b4f1) will increase coverage by 0.08%.
The diff coverage is 81.81%.

@@              Coverage Diff              @@
##             develop    #6113      +/-   ##
=============================================
+ Coverage      43.23%   43.31%   +0.08%     
- Complexity      8846     8859      +13     
=============================================
  Files           1094     1094              
  Lines          77137    77137              
  Branches       10057    10057              
=============================================
+ Hits           33350    33414      +64     
+ Misses         39623    39560      -63     
+ Partials        4164     4163       -1     
Impacted Files Coverage Δ
...cketmq/acl/plain/RemoteAddressStrategyFactory.java 89.51% <81.81%> (ø)
.../rocketmq/client/producer/RequestFutureHolder.java 81.39% <0.00%> (-6.98%) ⬇️
.../org/apache/rocketmq/remoting/netty/TlsHelper.java 71.57% <0.00%> (-6.32%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-4.35%) ⬇️
...tmq/remoting/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) ⬇️
...rg/apache/rocketmq/remoting/netty/NettyLogger.java 13.60% <0.00%> (-1.37%) ⬇️
...rocketmq/client/impl/factory/MQClientInstance.java 46.82% <0.00%> (-1.19%) ⬇️
...cketmq/broker/schedule/ScheduleMessageService.java 56.91% <0.00%> (-1.14%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 60.79% <0.00%> (-0.89%) ⬇️
...rocketmq/broker/processor/PopMessageProcessor.java 36.68% <0.00%> (-0.46%) ⬇️
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@TheR1sing3un TheR1sing3un left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@RongtongJin RongtongJin changed the title [ISSUE #6112] fix typos [ISSUE #6112] Fix typos in RemoteAddressStrategyFactory Feb 19, 2023
@RongtongJin RongtongJin merged commit cce65a6 into apache:develop Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix typos
6 participants