Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6092] fix: wrong brokerConfigPath when init configuration #6093

Merged
merged 2 commits into from
Feb 21, 2023
Merged

[ISSUE #6092] fix: wrong brokerConfigPath when init configuration #6093

merged 2 commits into from
Feb 21, 2023

Conversation

leizhiyuan
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

fix #6092

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@leizhiyuan leizhiyuan changed the title fix: wrong brokerConfigPath when init configuration [ISSUE #6092] fix: wrong brokerConfigPath when init configuration Feb 16, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #6093 (787cdd1) into develop (c4c3c61) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             develop    #6093   +/-   ##
==========================================
  Coverage      43.24%   43.24%           
- Complexity      8856     8857    +1     
==========================================
  Files           1094     1094           
  Lines          77146    77144    -2     
  Branches       10060    10060           
==========================================
  Hits           33361    33361           
+ Misses         39624    39618    -6     
- Partials        4161     4165    +4     
Impacted Files Coverage Δ
...a/org/apache/rocketmq/broker/BrokerController.java 43.14% <100.00%> (-0.11%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-4.35%) ⬇️
...apache/rocketmq/store/ha/GroupTransferService.java 92.30% <0.00%> (-1.29%) ⬇️
...cketmq/broker/schedule/ScheduleMessageService.java 56.91% <0.00%> (-1.14%) ⬇️
...a/org/apache/rocketmq/store/StoreStatsService.java 33.97% <0.00%> (-1.11%) ⬇️
...he/rocketmq/controller/impl/DLedgerController.java 65.96% <0.00%> (-0.53%) ⬇️
...rocketmq/client/impl/factory/MQClientInstance.java 46.82% <0.00%> (-0.30%) ⬇️
...main/java/org/apache/rocketmq/store/CommitLog.java 65.13% <0.00%> (-0.11%) ⬇️
...apache/rocketmq/store/timer/TimerMessageStore.java 54.15% <0.00%> (-0.10%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (ø)
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RongtongJin RongtongJin merged commit 0769414 into apache:develop Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setBrokerConfigPath not invoked correctly in BrokerStartup,which will persist brokerconfig to wrong location
5 participants