Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6087] fix typos #6091

Merged
merged 1 commit into from
Feb 21, 2023
Merged

[ISSUE #6087] fix typos #6091

merged 1 commit into from
Feb 21, 2023

Conversation

hardyfish
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

close #6087

Brief changelog

fix typos

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Attention: Patch coverage is 67.74194% with 10 lines in your changes missing coverage. Please review.

Project coverage is 43.22%. Comparing base (5a8818b) to head (b2b19b0).
Report is 787 commits behind head on develop.

Files with missing lines Patch % Lines
.../java/org/apache/rocketmq/acl/common/AclUtils.java 67.74% 5 Missing and 5 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6091      +/-   ##
=============================================
+ Coverage      43.21%   43.22%   +0.01%     
- Complexity      8840     8845       +5     
=============================================
  Files           1094     1094              
  Lines          77135    77137       +2     
  Branches       10057    10057              
=============================================
+ Hits           33332    33344      +12     
+ Misses         39635    39625      -10     
  Partials        4168     4168              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Oliverwqcwrw Oliverwqcwrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hardyfish
Copy link
Contributor Author

please help me merge, thank you.

@yuz10 yuz10 merged commit e3d173b into apache:develop Feb 21, 2023
mxsm pushed a commit to mxsm/rocketmq that referenced this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix typos
5 participants