Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5866] fix client-side memory leak of inactive channel #5867

Merged
merged 5 commits into from
Jun 13, 2023

Conversation

imzs
Copy link
Contributor

@imzs imzs commented Jan 11, 2023

caigy
caigy previously approved these changes Feb 15, 2023
Copy link
Contributor

@caigy caigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fuyou001
fuyou001 previously approved these changes Jun 12, 2023
@imzs imzs dismissed stale reviews from caigy and fuyou001 via 8a2a840 June 13, 2023 07:43
@codecov-commenter
Copy link

Codecov Report

Merging #5867 (8a2a840) into develop (ad4cc95) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #5867      +/-   ##
=============================================
+ Coverage      42.65%   42.67%   +0.02%     
- Complexity      9101     9112      +11     
=============================================
  Files           1125     1125              
  Lines          79875    79880       +5     
  Branches       10383    10383              
=============================================
+ Hits           34071    34090      +19     
+ Misses         41527    41521       -6     
+ Partials        4277     4269       -8     
Impacted Files Coverage Δ
...e/rocketmq/remoting/netty/NettyRemotingClient.java 39.47% <100.00%> (-0.19%) ⬇️

... and 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fuyou001 fuyou001 merged commit 4291971 into apache:develop Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants