[ISSUE #5663] Fix Messages may be lost when SyncStateSet expand in extreme scenarios #5798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… missing messages
Codecov Report
@@ Coverage Diff @@
## develop #5798 +/- ##
=============================================
- Coverage 43.44% 43.40% -0.05%
- Complexity 8824 8832 +8
=============================================
Files 1090 1090
Lines 76617 76649 +32
Branches 10006 10010 +4
=============================================
- Hits 33289 33266 -23
- Misses 39166 39225 +59
+ Partials 4162 4158 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mxsm
reviewed
Jan 2, 2023
store/src/main/java/org/apache/rocketmq/store/ha/autoswitch/AutoSwitchHAService.java
Outdated
Show resolved
Hide resolved
# Conflicts: # store/src/main/java/org/apache/rocketmq/store/ha/autoswitch/AutoSwitchHAService.java
mxsm
reviewed
Jan 5, 2023
store/src/main/java/org/apache/rocketmq/store/ha/autoswitch/AutoSwitchHAService.java
Outdated
Show resolved
Hide resolved
store/src/main/java/org/apache/rocketmq/store/ha/autoswitch/AutoSwitchHAService.java
Outdated
Show resolved
Hide resolved
RongtongJin
changed the title
RongtongJin
reviewed
Jan 6, 2023
store/src/main/java/org/apache/rocketmq/store/ha/autoswitch/AutoSwitchHAService.java
Outdated
Show resolved
Hide resolved
store/src/main/java/org/apache/rocketmq/store/ha/autoswitch/AutoSwitchHAService.java
Outdated
Show resolved
Hide resolved
|
@RongtongJin PTLA |
|
Hi @hzh0425 Could you help reslove the conflict? |
# Conflicts: # store/src/test/java/org/apache/rocketmq/store/ha/autoswitch/AutoSwitchHATest.java
RongtongJin
approved these changes
Mar 13, 2023
fuyou001
pushed a commit
to fuyou001/rocketmq
that referenced
this pull request
Mar 16, 2023
… in extreme scenarios (apache#5798) * Add a new state 'isSynchronizingSyncStateSet' to Solve the problem of missing messages * pass checkstyle * Using readWriteLock to replace synchronized in AutoSwitchHAService * Fix lock issue * Remove unnecessary 'remoteSyncStateSet.clear' * optimize import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… missing messages
Make sure set the target branch to
developWhat is the purpose of the change
Close #5663
Brief changelog
Add a new state 'isSynchronizingSyncStateSet' in 'AutoSwitchHAService' to Solve the problem of missing messages
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.