Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Unnecessary broker back notification (notifyConsumerIdsChanged) in broadcast mode #8483

Closed
1 task done
yx9o opened this issue Aug 3, 2024 · 0 comments · Fixed by #8484
Closed
1 task done

Comments

@yx9o
Copy link
Contributor

yx9o commented Aug 3, 2024

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

Hi, community, recently I found an unnecessary broker reverse notification (notifyConsumerIdsChanged) in broadcast mode.

Background: In one of our online incident investigations, there were thousands of single group broadcast clients, and it was found that the broker had been sending notifyConsumerIdsChanged requests to the broadcast clients.

image

企业微信截图_8e88e985-7986-494f-8971-8a4aafacbd2f

企业微信截图_b5c15368-849d-4cd1-bf6d-7bbdc80bbd29

企业微信截图_b0d6dd68-a323-4025-9b26-3acc99074024

Motivation

Analysis: In broadcast mode, each Consumer consumes complete data, and its rebalance operation only updates the messagequeue information, which is also updated by a scheduled task and has nothing to do with the change in the number of Consumers. So I think that in broadcast mode, if there is any change in Consumer, there is no need to send notifyConsumerIdsChanged requests to all broadcast clients.

Describe the Solution You'd Like

Modification: When sending ConsumerGroupEvent.CHANGE events in ConsumerManager, it is sent only when it is determined to be in non-broadcast mode.

Describe Alternatives You've Considered

No

Additional Context

No response

yx9o added a commit to yx9o/rocketmq that referenced this issue Aug 3, 2024
…(notifyConsumerIdsChanged) in broadcast mode
lizhanhui pushed a commit that referenced this issue Aug 30, 2024
…yConsumerIdsChanged) in broadcast mode (#8484)

* [ISSUE #8483] Optimize unnecessary broker reverse notification (notifyConsumerIdsChanged) in broadcast mode

* Update

* Update test

* Update test
lizhanhui pushed a commit to qianye1001/rocketmq that referenced this issue Aug 30, 2024
…(notifyConsumerIdsChanged) in broadcast mode (apache#8484)

* [ISSUE apache#8483] Optimize unnecessary broker reverse notification (notifyConsumerIdsChanged) in broadcast mode

* Update

* Update test

* Update test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant