Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add two metrics rocketmq_create_topic_time and rocketmq_create_subscription_time #8211

Closed
Stephanie0002 opened this issue May 27, 2024 · 0 comments · Fixed by #8212

Comments

@Stephanie0002
Copy link
Contributor

Stephanie0002 commented May 27, 2024

Is Your Feature Request Related to a Problem?

The existing observable system of this project lacks broker-side monitoring of the creation time of topic and subscription group.

Describe the Solution You'd Like

Add two metrics rocketmq_create_topic_time and rocketmq_create_subscription_time as following:

Type Name Unit Description Label
histogram rocketmq_create_topic_time millisecond The topic creation time:
le_10_ms
le_100_ms
le_1_s
le_3_s
le_5_s
le_overflow
cluster,node_type,node_id,request_is_success,is_system
histogram rocketmq_create_subscription_time millisecond The subscription group creation time:
le_10_ms
le_100_ms
le_1_s
le_3_s
le_5_s
le_overflow
cluster,node_type,node_id,request_is_success

Describe Alternatives You've Considered

  1. Plan to utilize histogram-type metrics and counter-type metrics.
    Histogram: A metric type that illustrates the frequency distribution of monitored data points through sampling.
  2. Add metric variables within the BrokerMetricsManager class: createTopicTime and createSubscriptionTime.
  3. Incorporate corresponding constants in the BrokerMetricsConstant class.
    a. Specifically, introduce the LABEL_REQUEST_IS_SUCCESS constant to denote the success of topic creation requests.
  4. Construct the respective metrics within the initRequestMetrics method of the BrokerMetricsManager class.
  5. Update these metrics in the topic creation function and subscription creation function of the AdminBrokerProcessor class.
  6. Configure buckets

Additional Context

No response

RongtongJin pushed a commit that referenced this issue May 31, 2024
…d rocketmq_consumer_group_create_execution_time (#8212)

* Add tow metric createTopicTime and createSubscriptionTime in broker

* roll back BrokerConfig.java

* Add metric view of createTopicTime and createSubscriptionTime in broker

* Add two metric rocketmq_active_topic_number and rocketmq_active_subscription_number

Signed-off-by: 黄梓淇 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant